atomic-ehr-codegen-python-us-core-profiles: doc fix + regenerate fhir_types (codegen canary)#37
Open
ryukzak wants to merge 2 commits into
Open
atomic-ehr-codegen-python-us-core-profiles: doc fix + regenerate fhir_types (codegen canary)#37ryukzak wants to merge 2 commits into
ryukzak wants to merge 2 commits into
Conversation
…ion name to client: "fhirpy" The README and post.py docstring referenced `fhirpyClient: true`, but the current @atomic-ehr/codegen API (and this example`s generate.ts) use `client: "fhirpy"`. Update the three references to match.
…pes with @atomic-ehr/codegen canary Regenerated with @atomic-ehr/codegen@0.0.16-canary.20260626094300.e87ff88. Canary changes: concrete resources type resourceType as `str` (pattern still fixes the value) instead of `Literal[...]`, abstract base types (Resource, DomainResource) no longer carry a resourceType default, and FhirpyBaseModel guards against PydanticUndefined so it does not register a class-level resourceType for those abstract types. Verified: mypy clean (35 files), load.py / avg.py run, and post.py round-trips a transaction against a local Aidbox with typed read-back.
ryukzak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to
developer-experience/atomic-ehr-codegen-python-us-core-profiles:1. Docs: correct the codegen option name
The README and
post.pydocstring referencedfhirpyClient: true, but the current@atomic-ehr/codegenAPI — and this example's owngenerate.ts— useclient: "fhirpy". Fixed the three stale references.2. Regenerate
fhir_types/with the codegen canaryRegenerated with
@atomic-ehr/codegen@0.0.16-canary.20260626094300.e87ff88(package.jsonupdated accordingly). Diff is small (8 files):resourceTypeasstr(thepatternstill fixes the value) instead ofLiteral[...].Resource,DomainResource) no longer carry aresourceTypedefault.FhirpyBaseModelguards againstPydanticUndefined, so it no longer registers a class-levelresourceTypefor those abstract types (which concrete subclasses would shadow).Verification (after regeneration)
mypy .→ no issues (35 source files, strict mode)python load.py→ writesbundle.json(10 entries)python avg.py→Avg BP: 125.2/82.0 mmHg (n=5)python post.py→ transaction committed against a local Aidbox, observations read back as typedObservationresourcesNote:
package.jsonnow pins an ephemeral canary build. If you'd prefer to wait for a stable release before merging the regeneration, the doc fix (commit 1) stands on its own.